From 19b9b5c5575214b1b72c4783c00ee32312333d23 Mon Sep 17 00:00:00 2001 From: phyusin Date: Fri, 27 Oct 2017 13:28:25 +0630 Subject: [PATCH 1/3] add validation for payment method,print_setting,tax_profile --- app/models/payment_method_setting.rb | 2 ++ app/models/print_setting.rb | 2 ++ app/models/tax_profile.rb | 3 ++- app/views/print_settings/edit.html.erb | 2 +- 4 files changed, 7 insertions(+), 2 deletions(-) diff --git a/app/models/payment_method_setting.rb b/app/models/payment_method_setting.rb index 1a7f26b1..2ffff25d 100755 --- a/app/models/payment_method_setting.rb +++ b/app/models/payment_method_setting.rb @@ -1,2 +1,4 @@ class PaymentMethodSetting < ApplicationRecord + # validations + validates_presence_of :payment_method, :gateway_communication_type, :gateway_url, :auth_token, :merchant_account_id end diff --git a/app/models/print_setting.rb b/app/models/print_setting.rb index b715af52..54afdfae 100755 --- a/app/models/print_setting.rb +++ b/app/models/print_setting.rb @@ -1,2 +1,4 @@ class PrintSetting < ApplicationRecord + # validations + validates_presence_of :name, :unique_code, :font, :api_settings, :printer_name, :page_width, :page_height, :print_copies, :heading_space end diff --git a/app/models/tax_profile.rb b/app/models/tax_profile.rb index 6e14b2f8..e478ecd5 100755 --- a/app/models/tax_profile.rb +++ b/app/models/tax_profile.rb @@ -1,4 +1,5 @@ class TaxProfile < ApplicationRecord default_scope { order('order_by asc') } - + # validations + validates_presence_of :name, :rate end diff --git a/app/views/print_settings/edit.html.erb b/app/views/print_settings/edit.html.erb index 6d4f0ded..bfb0ef5b 100755 --- a/app/views/print_settings/edit.html.erb +++ b/app/views/print_settings/edit.html.erb @@ -4,7 +4,7 @@ - <%= link_to t('.new', :default => t("views.btn.new")), print_settings_path %> + <%= link_to t('.back', :default => t("views.btn.back")), print_settings_path %> From d916c262d70d8d8699da1327722d33d4e3e20a10 Mon Sep 17 00:00:00 2001 From: phyusin Date: Fri, 27 Oct 2017 13:51:45 +0630 Subject: [PATCH 2/3] validation for commission, commissioner --- app/models/commission.rb | 3 +++ app/models/commissioner.rb | 3 +++ app/views/settings/commissions/_form.html.erb | 2 +- 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/app/models/commission.rb b/app/models/commission.rb index 40d69f81..84771e9f 100755 --- a/app/models/commission.rb +++ b/app/models/commission.rb @@ -8,6 +8,9 @@ class Commission < ApplicationRecord has_many :commissioners has_many :product_commissions + # validations + validates_presence_of :commission_type, :amount + private def generate_custom_id self.commission_id = SeedGenerator.generate_id(self.class.name, 'COM') diff --git a/app/models/commissioner.rb b/app/models/commissioner.rb index 17fa2036..2b262afc 100755 --- a/app/models/commissioner.rb +++ b/app/models/commissioner.rb @@ -4,4 +4,7 @@ class Commissioner < ApplicationRecord has_many :in_juties has_many :product_commissions scope :active, -> { where(is_active: true) } + + # validations + validates_presence_of :name end diff --git a/app/views/settings/commissions/_form.html.erb b/app/views/settings/commissions/_form.html.erb index 15bdf52a..a1a2368a 100755 --- a/app/views/settings/commissions/_form.html.erb +++ b/app/views/settings/commissions/_form.html.erb @@ -7,7 +7,7 @@
<%= f.label :product_code, 'Product' %> - <%= f.collection_select :product_code, @products, :id, :name, {prompt: 'Select a Product'}, {class: 'form-control'} %>
+ <%= f.collection_select :product_code, MenuItem.all.order('name asc'), :id, :name, {prompt: 'Select a Product'}, {class: 'form-control'} %>
<%= f.input :commission_type, :collection => ['Percentage','Net Amount'], prompt: 'Select Commission Type', class: 'form-control' %> <%= f.input :amount %> <%= f.input :is_active %> Active From ef05aec1db4211e2a62461b78aca456946d8bdb3 Mon Sep 17 00:00:00 2001 From: phyusin Date: Fri, 27 Oct 2017 17:00:56 +0630 Subject: [PATCH 3/3] add localization for all form data --- app/views/crm/dining_queues/edit.html.erb | 6 +- app/views/crm/dining_queues/index.html.erb | 4 +- app/views/crm/dining_queues/new.html.erb | 6 +- app/views/print_settings/edit.html.erb | 6 +- app/views/print_settings/index.html.erb | 20 +-- app/views/print_settings/new.html.erb | 6 +- app/views/print_settings/show.html.erb | 24 ++-- app/views/settings/accounts/edit.html.erb | 6 +- app/views/settings/accounts/index.html.erb | 18 +-- app/views/settings/accounts/new.html.erb | 6 +- app/views/settings/accounts/show.html.erb | 20 +-- .../settings/cashier_terminals/edit.html.erb | 6 +- .../settings/cashier_terminals/index.html.erb | 18 +-- .../settings/cashier_terminals/new.html.erb | 6 +- .../settings/cashier_terminals/show.html.erb | 51 ++++--- .../settings/commissioners/edit.html.erb | 6 +- .../settings/commissioners/index.html.erb | 20 +-- app/views/settings/commissioners/new.html.erb | 6 +- .../settings/commissioners/show.html.erb | 20 +-- app/views/settings/commissions/edit.html.erb | 6 +- app/views/settings/commissions/index.html.erb | 14 +- app/views/settings/commissions/new.html.erb | 6 +- app/views/settings/commissions/show.html.erb | 16 +-- app/views/settings/employees/edit.html.erb | 6 +- app/views/settings/employees/index.html.erb | 14 +- app/views/settings/employees/new.html.erb | 6 +- app/views/settings/employees/show.html.erb | 16 +-- app/views/settings/item_sets/edit.html.erb | 6 +- app/views/settings/item_sets/index.html.erb | 21 ++- app/views/settings/item_sets/new.html.erb | 6 +- app/views/settings/item_sets/show.html.erb | 14 +- .../settings/menu_categories/edit.html.erb | 6 +- .../settings/menu_categories/index.html.erb | 30 +++-- .../settings/menu_categories/new.html.erb | 6 +- .../settings/menu_categories/show.html.erb | 47 +++---- .../menu_item_attributes/edit.html.erb | 6 +- .../menu_item_attributes/index.html.erb | 28 ++-- .../menu_item_attributes/new.html.erb | 6 +- .../menu_item_attributes/show.html.erb | 14 +- .../menu_item_instances/edit.html.erb | 6 +- .../menu_item_instances/index.html.erb | 39 +++--- .../settings/menu_item_instances/new.html.erb | 6 +- .../menu_item_instances/show.html.erb | 24 ++-- .../settings/menu_item_options/edit.html.erb | 6 +- .../settings/menu_item_options/index.html.erb | 25 ++-- .../settings/menu_item_options/new.html.erb | 6 +- .../settings/menu_item_options/show.html.erb | 16 +-- app/views/settings/menus/edit.html.erb | 6 +- app/views/settings/menus/index.html.erb | 25 ++-- app/views/settings/menus/new.html.erb | 6 +- app/views/settings/menus/show.html.erb | 50 +++---- .../order_queue_stations/index.html.erb | 20 +-- .../order_queue_stations/show.html.erb | 26 ++-- .../payment_method_settings/edit.html.erb | 6 +- .../payment_method_settings/index.html.erb | 14 +- .../payment_method_settings/new.html.erb | 6 +- .../payment_method_settings/show.html.erb | 18 +-- app/views/settings/products/edit.html.erb | 6 +- app/views/settings/products/index.html.erb | 23 ++-- app/views/settings/products/new.html.erb | 6 +- app/views/settings/products/show.html.erb | 26 ++-- app/views/settings/promotions/edit.html.erb | 6 +- app/views/settings/promotions/index.html.erb | 24 ++-- app/views/settings/promotions/new.html.erb | 6 +- app/views/settings/promotions/show.html.erb | 26 ++-- .../settings/set_menu_items/edit.html.erb | 6 +- .../settings/set_menu_items/index.html.erb | 84 +++++++++--- .../settings/set_menu_items/new.html.erb | 6 +- .../settings/simple_menu_items/edit.html.erb | 6 +- .../settings/simple_menu_items/index.html.erb | 126 ++++++++++++------ .../settings/simple_menu_items/new.html.erb | 6 +- .../settings/simple_menu_items/show.html.erb | 47 +++---- app/views/settings/tax_profiles/edit.html.erb | 6 +- .../settings/tax_profiles/index.html.erb | 18 +-- app/views/settings/tax_profiles/new.html.erb | 6 +- app/views/settings/tax_profiles/show.html.erb | 18 +-- app/views/settings/zones/edit.html.erb | 6 +- app/views/settings/zones/index.html.erb | 12 +- app/views/settings/zones/new.html.erb | 6 +- app/views/settings/zones/show.html.erb | 32 ++--- config/locales/en.yml | 14 ++ 81 files changed, 735 insertions(+), 621 deletions(-) diff --git a/app/views/crm/dining_queues/edit.html.erb b/app/views/crm/dining_queues/edit.html.erb index 7e8081cb..bf0c3b10 100755 --- a/app/views/crm/dining_queues/edit.html.erb +++ b/app/views/crm/dining_queues/edit.html.erb @@ -2,9 +2,9 @@
<%= render 'form', dining_queue: @dining_queue %> diff --git a/app/views/crm/dining_queues/index.html.erb b/app/views/crm/dining_queues/index.html.erb index db7c7d81..d7ee6f06 100755 --- a/app/views/crm/dining_queues/index.html.erb +++ b/app/views/crm/dining_queues/index.html.erb @@ -1,8 +1,8 @@
+
+
+
+
<%= t("views.right_panel.header.menu_category") %>
+
view_headline <%= t("views.right_panel.header.page_detail") %>
+

+ 1) <%= t("views.right_panel.detail.menu") %> - <%= t("views.right_panel.detail.menu_txt") %> <%= t("views.right_panel.detail.name_txt2") %>
+ 2) <%= t("views.right_panel.detail.name") %> - <%= t("views.right_panel.detail.menu_categories_txt") %> <%= t("views.right_panel.detail.name_txt2") %>
+ 3) <%= t("views.right_panel.detail.alt_name") %> - <%= t("views.right_panel.detail.alt_name_txt") %> <%= t("views.right_panel.detail.for") %> <%= t("views.right_panel.detail.menu_categories_txt") %>
+ 4) <%= t("views.right_panel.detail.is_available") %> - <%= t("views.right_panel.detail.menu_categories_txt") %> <%= t("views.right_panel.detail.status_txt") %>
+ 4) <%= t("views.right_panel.detail.order_by") %> - <%= t("views.right_panel.detail.order_txt") %> <%= t("views.right_panel.detail.for") %> <%= t("views.right_panel.detail.menu_categories_txt") %>
+ 5) <%= t("views.right_panel.detail.created_at") %> - <%= t("views.right_panel.detail.created_at_txt") %> <%= t("views.right_panel.detail.menu_categories_txt") %>
+ 6) <%= t("views.right_panel.detail.actions") %> - <%= t("views.right_panel.detail.actions_txt2") %> <%= t("views.right_panel.detail.menu_categories_txt") %>
+

+
list <%= t("views.right_panel.header.button_lists") %>
+

+ 1) <%= t("views.right_panel.button.edit") %> - <%= t("views.right_panel.detail.edit_btn_txt") %> <%= t("views.right_panel.detail.menu_categories_txt") %>
+ 2) <%= t("views.right_panel.button.delete") %> - <%= t("views.right_panel.detail.delete_btn_txt") %> <%= t("views.right_panel.detail.menu_categories_txt") %>
+

+
<%= t("views.right_panel.header.menu_items") %>
+
view_headline <%= t("views.right_panel.header.page_detail") %>
+

+ 1) <%= t("views.right_panel.detail.item_code") %> - <%= t("views.right_panel.detail.code_txt") %> <%= t("views.right_panel.detail.for") %> <%= t("views.right_panel.detail.menu_item_txt") %>
+ 2) <%= t("views.right_panel.detail.name") %> - <%= t("views.right_panel.detail.menu_item_txt") %> <%= t("views.right_panel.detail.name_txt2") %>
+ 3) <%= t("views.right_panel.detail.alt_name") %> - <%= t("views.right_panel.detail.alt_name_txt") %> <%= t("views.right_panel.detail.for") %> <%= t("views.right_panel.detail.menu_item_txt") %>
+ 4) <%= t("views.right_panel.detail.type") %> - <%= t("views.right_panel.detail.type_txt") %> <%= t("views.right_panel.detail.for") %> <%= t("views.right_panel.detail.menu_item_txt") %>
+ 5) <%= t("views.right_panel.detail.parent_item") %> - <%= t("views.right_panel.detail.parent_item_txt") %>
+ 6) <%= t("views.right_panel.detail.actions") %> - <%= t("views.right_panel.detail.actions_txt") %> <%= t("views.right_panel.detail.menu_item_txt") %>
+

+
list <%= t("views.right_panel.header.button_lists") %>
+

+ 1) <%= t("views.right_panel.button.new_simple_menu_item") %> - <%= t("views.right_panel.detail.create_btn_txt") %> <%= t("views.right_panel.detail.simple_menu_item_txt") %>
+ 2) <%= t("views.right_panel.button.new_set_menu_item") %> - <%= t("views.right_panel.detail.create_btn_txt") %> <%= t("views.right_panel.detail.set_menu_item_txt") %>
+ 3) <%= t("views.right_panel.button.show") %> - <%= t("views.right_panel.detail.show_btn_txt") %> <%= t("views.right_panel.detail.menu_item_txt") %>
+ 4) <%= t("views.right_panel.button.edit") %> - <%= t("views.right_panel.detail.edit_btn_txt") %> <%= t("views.right_panel.detail.menu_item_txt") %>
+

+ ----------------------------------------------------------------- +
list <%= t("views.right_panel.header.link_lists") %>
+

+ 1) <%= t("views.right_panel.button.home") %> - <%= t("views.right_panel.detail.home_txt") %>
+ 2) <%= t("views.right_panel.button.back") %> - <%= t("views.right_panel.detail.home_txt") %>
+ 3) <%= t("en.accounts") %> - <%= t("views.right_panel.detail.back_txt") %> <%= t("views.right_panel.detail.accounts_txt") %>
+ 4) <%= t("views.right_panel.button.menu") %> - <%= t("views.right_panel.detail.back_txt") %> <%= t("views.right_panel.detail.menu_txt") %>
+ 5) <%= t("views.right_panel.button.menu_categories") %> - <%= t("views.right_panel.detail.back_txt") %> <%= t("views.right_panel.detail.menu_categories_txt") %>
+ 6) <%= t("views.right_panel.button.item_set") %> - <%= t("views.right_panel.detail.back_txt") %> <%= t("views.right_panel.detail.item_set_txt") %>
+ 7) <%= t("views.right_panel.button.item_attributes") %> - <%= t("views.right_panel.detail.back_txt") %> <%= t("views.right_panel.detail.item_attributes_txt") %>
+ 8) <%= t("views.right_panel.button.item_options") %> - <%= t("views.right_panel.detail.back_txt") %> <%= t("views.right_panel.detail.item_options_txt") %>
+

-
-
-
- Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod - tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, - quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo - consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse -
-
-
-
\ No newline at end of file +
+
+
\ No newline at end of file diff --git a/app/views/settings/simple_menu_items/new.html.erb b/app/views/settings/simple_menu_items/new.html.erb index e9baecc3..3992c8c3 100755 --- a/app/views/settings/simple_menu_items/new.html.erb +++ b/app/views/settings/simple_menu_items/new.html.erb @@ -19,9 +19,9 @@